feat: exposing options to allow better flow customisation#164
Closed
falleco wants to merge 5 commits intomatter-labs:mainfrom
Closed
feat: exposing options to allow better flow customisation#164falleco wants to merge 5 commits intomatter-labs:mainfrom
falleco wants to merge 5 commits intomatter-labs:mainfrom
Conversation
falleco
changed the title
Contributor
Author
|
Can this be merged as it is and a new version released? |
Merged
Contributor
|
Merged here: #167 For whatever reason the merge commits weren't signed, but rebasing worked since there were no conflicts! |
auto-merge was automatically disabled
August 1, 2025 01:30
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hello, we've been using zksync-sso on and upcoming project, and needed to change it to allow better customisation:
Communicatorinterface, theWalletProviderwas always creating the popup. We changed it so that it’s now possible to pass anyCommunicatorwhen instantiating the provider. We still keepPopupCommunicatoras the default, just like it is today.PopupCommunicator: It’s now possible to provide height and width, as well as its initial positioning.StorageLikeonSigner: on theSignerwe were forcing the storage to be localStorage, and on some contexts we need to use other things here, so we changed to be able to provide it all the way down toSignerinstance aStorageLikeoption.Additional context
I think thats all, if you need us to make any adjustment, please ping us. Other than that, the build is still executing and the existing tests are passing.